[Bug 493957] Review Request: skyviewer - Program to display HEALPix-based skymaps in FITS files

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493957





--- Comment #3 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-04-04 10:18:52 EDT ---
rpmlint output:
skyviewer.x86_64: W: file-not-utf8 /usr/share/doc/skyviewer-1.0.0/test_iqu.fits
3 packages and 0 specfiles checked; 0 errors, 1 warnings.

No problem with this one.

- You didn't try to build in mock, did you? Missing BRs:
BuildRequires:  desktop-file-utils
BuildRequires:  libQGLViewer-devel
BuildRequires:  qt4-devel

After this builds fine.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK

MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. NEEDSFIX
MUST: The License field in the package spec file must match the actual license.
NEEDSFIX
- There is no license file included, or any license mentioned in the source
code or the homepage. Must get license information from upstream before the
package can be approved.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK 
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Optflags are used and time stamps preserved. OK
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK

MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. NEEDSFIX
- Add general.txt and notes-ngp.txt

MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. OK
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. OK
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. OK
MUST: Packages does not contain any .la libtool archives. OK
MUST: Desktop files are installed properly. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK

SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. NEEDSFIX

SHOULD: The package builds in mock. NEEDSFIX (Missing BRs mentioned above.)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.