[Bug 494148] Review Request: soci - The database access library for C++ programmers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494148


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |bugs.michael at gmx.net
         AssignedTo|nobody at fedoraproject.org    |bugs.michael at gmx.net
               Flag|                            |fedora-review?




--- Comment #1 from Michael Schwendt <bugs.michael at gmx.net>  2009-04-05 11:54:51 EDT ---
* For all -devel sub-packages change "BuildRequires" to "Requires", because you
want the builds to depend on the {mysql,sqlite,postgresql}-devel packages.
Plus, add the missing "Requires: %name-devel = %version-%release" as the core
soci headers are needed.

* For the optional Oracle Database builds, consider adding a conditional build
parameter (see /usr/share/doc/rpm-*/conditionalbuilds), so you could simple
build "--with oracle" to enable the optional packages instead of having to edit
the spec file.

* The package %description does not mention the project name "SOCI" anywhere.

* Why is the tarball not downloaded from the soci.sf.net download location but
from your opentrep project space? It differs by ~4MiB. Where does that tarball
come from? Is it a checkout from a source code management system? In that case
you need to follow the guidelines for 1) documenting this in the spec file, and
2) proper pre-/post-release package versioning.

* Package (except for the MySQL backend) doesn't adhere to the compiler flags
guidelines.

* Directory %{_includedir}/%{name}/backends/ is not included.

> %package        devel
> [...]
> Requires(post): info
> Requires(preun): info

"info" is not used. -devel package doesn't contain any post/preun scriptlet.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.