[Bug 453851] Review Request: globus-common - Globus Toolkit - Common Library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453851





--- Comment #9 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-04-06 08:51:30 EDT ---
(In reply to comment #8)

> ! rpmlint output - please fix the mixed-spaces-tabs issue. Also consider adding
>   the license file to all packages as doc. I don't quite understand what the
>   %post script for progs does, so please explain.

The mixed-spaces-tabs warning is due to a bug in rpmlint, if you update to
rpmlint-0.87-1 (currently in the testing repo) where the bug has been fixed,
the warning goes away.

The %post script generates the two files labelled as %ghost in the filelist:
%ghost %{_datadir}/globus/setup/globus-sh-tools-vars.sh
%ghost %{_datadir}/globus/globus-sh-tools-vars.sh

> ! Package follows the Fedora packaging guidelines
>   why are the file lists packaged? (such as
> /usr/share/globus/packages/globus_common/gcc32pthr_rtl.filelist)

These are GPT (grid-packaging-tools) metadata files, used by e.g. gpt-verify
and other GPT tools.

> ! Sources matches upstream, but...
>   If you insist on chopping the source tarball, please do it according to
>   http://fedoraproject.org/wiki/Packaging/SourceURL,
>   section "When upstream uses prohibited code". This section IMO matches
>   best what you want to achieve

I think a script is an overkill here, since the instructions are quite simple
(extract a complete subdirectory) and can be stated in a comment. The reviewer
of globus-core had a similar request (at the time there was no comment in the
spec files), and when I added the comment as it is now he was satisfied with
it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.