[Bug 494148] Review Request: soci - The database access library for C++ programmers

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494148





--- Comment #5 from Michael Schwendt <bugs.michael at gmx.net>  2009-04-06 10:31:33 EDT ---
> on a formal point of view,
> that I did a fork of the code from version 3.0.0

This asks for trouble. At least Debian and Mandriva ship packages of SOCI,
albeit an older release as it seems.

http://fedoraproject.org/wiki/PackageMaintainers/WhyUpstream

Making up SONAMEs and modifying the ABI and API (header location for default
include paths) typically is frowned upon.

Remains the question whether it would be more convenient for you to rename the
project at least slightly?

The "empty" and SQLite backends are not included in the upstream 3.0.0 release.
The diff between pristine 3.0.0 and your tarball is ~4 MB, not just due to
adding the autotools framework.


> there is a "configure" script, but
> absolutely not the classical (from the GNU autotools suite) one,

You need not use the %configure macro, if the available "configure" is a custom
one that is incompatible. Could the SOCI configure script be used directly? Or
would it need to be patched heavily (it's just 2K) to do a good job?


> What did you mean by "Directory %{_includedir}/%{name}/backends/
> is not included"?

https://fedoraproject.org/wiki/Packaging/UnownedDirectories

$ diff -u soci.spec.orig soci.spec
--- soci.spec.orig      2009-04-05 10:43:01.000000000 +0200
+++ soci.spec   2009-04-06 16:11:59.000000000 +0200
@@ -222,6 +222,7 @@
 %doc ABOUT-NLS AUTHORS ChangeLog COPYING NEWS README
 %dir %{_includedir}/%{name}
 %{_includedir}/%{name}/core
+%dir %{_includedir}/%{name}/backends
 %{_includedir}/%{name}/backends/empty
 %{_bindir}/%{name}-config
 %{_libdir}/lib%{name}_core.so


> What did you mean by "Package does not adhere to the
> compiler flag guidelines"?

That only the MySQL backend uses Fedora's global optflags during compilation.
The rest of the code builds with other flags.


> How can I override the compiler flags, so as to use
> $RPM_OPT_FLAGS/%> {optflags}?
> Should I add something like CPPFLAGS="%{optflags}" in
> the %configure macro?  

Run "rpm --eval %configure" to see what the macro does. It exports CXXFLAGS, so
all you would need to do is make sure all Makefiles inherit $CXXFLAGS (which
would be the default with automake/autoconf unless you override the flags in a
way that doesn't accept CFLAGS/CXXFLAGS if passed in from the environment).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.