[Bug 492125] Review Request: mingw32-pangomm - MinGW Windows C++ interface for Pango

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492125


Mattias Ellert <mattias.ellert at fysast.uu.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         AssignedTo|nobody at fedoraproject.org    |mattias.ellert at fysast.uu.se
               Flag|                            |fedora-review?




--- Comment #1 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-04-07 11:25:11 EDT ---
Fedora review mingw32-pangomm-2.14.1-1.fc11.src.rpm 2008-04-07

* OK
! needs attention

* rpmlint output
  Only expected Errors/Warnings from a mingw package

* Package is named according to Fedora mingw packaging guidelines

* Spec file is named as the package

* Package follows the Fedora mingw packaging guidelines

* The stated license (LGPLv2+) is a Fedora approved license

* The stated license is the same as the one for the corresponding
  Fedora package

* The package contains the license file (COPYING)

* The spec file is written in legible English

* Sources matches upstream

  c67228ea93dd977394d2872b61754b53  pangomm-2.14.1.tar.bz2
  c67228ea93dd977394d2872b61754b53  SRPM/pangomm-2.14.1.tar.bz2

! Accoding to guidelines the version should match the version of the
  corresponding Fedora package. The version in Fedora 11 is now 2.24.0
  (built yesterday 2009-04-06 - so no shadow falls on the requester.)
  http://koji.fedoraproject.org/koji/buildinfo?buildID=96784

  Fedora 10 so far remains at 2.14.1 (in case a Fedora 10 package is
  considered)

* Package builds in mock (Fedora 10)

* BuildRequires look sane

* Owns the directories it creates

* No duplicate files

* %files has %defattr

* %clean clears %buildroot

* Specfile uses macros consistently

* Package does not own other's directories

* %install clears %buildroot

* Installed filenames are valid UTF8

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.