[Bug 453850] Review Request: globus-openssl - Openssl Library (virtual GPT glue package)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=453850





--- Comment #6 from Mattias Ellert <mattias.ellert at fysast.uu.se>  2009-04-07 19:24:23 EDT ---
(In reply to comment #4)
> (In reply to comment #3)
> > - Added comment documenting source
> 
> Sorry, but I don't see the comment documenting the source. Am I missing
> something?

Sorry for the confusion. I updated all the globus packages at the same time and
pasted the same entry in the bugzilla comment for all of them (which was the
right one for 28 of 30 packages). Since the source for this package is not
extracted from upstream like for the other packages, the comment added to the
other packages (which tells how the source was extracted from upstream) does
not apply to this package - so I did not add that comment to this package.

I will add a different comment to this package explaining what the source file
is and why there is no upstream source for this package.

> Other than this, there are a few other things I'd like to clarify:
> 
> * Why is this package not noarch? (The .pc file can go to /usr/shar/pkgconfig)

The content of the package differs for different architectures. (I guess you
realised that based on your comment 5.)

> * The guidelines say:
>     If (and only if) the source package includes the text of the license(s) in 
>     its own file, then that file, containing the text of the license(s) for the 
>     package must be included in %doc.
> 
> Here, the license file is supplied separately. Is there a reason that we should
> grant an exception to this package?  

I should just drop the license file. The argument I had for including it was
quite weak, and not really convincing, so I will not bother you with it.

(In reply to comment #5)
> I see that there are arch dependent non-binary files. Then, why are they going
> to %{_datadir} instead of %{_libdir}?  

The files in /usr/share/globus/packages are GPT metadata files. GPT expects all
metadata files to be in the same directory. GPT supports installing packages
from different architectures in parallel by using different filenames for
different architectures for architecture dependent metadata, so there are no
filename conflicts for a multi-arch installation. Even though the metadata
describes architecture dependent information, the metadata itself is
architecture independent. A query on the metadata can return information about
multiple architectures on a multi-arch installation.


An updated specfile is available here:

http://www.grid.tsl.uu.se/repos/globus/info/new/globus-openssl.spec

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.