[Bug 490399] (Rename) Review Request: WebKitGTK - GTK+ Web content engine library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490399





--- Comment #7 from Peter Gordon <peter at thecodergeek.com>  2009-04-07 19:56:13 EDT ---
Hi, Kevin - and thanks for the review. 

> 1. I'm a bit confused by what package name we should use here. 
> 
> domain: webkitgtk.org
> content on website: WebKitGTK+
> link to source on website: WebKitGTK+
> tar file downloaded: webkit-1.1.3.tar.gz
> 
> So, the choices seem to be 'WebKitGTK+', 'webkit', 'webkitgtk'. 
> Can you please ask upstream what the desired package name should be?
> Along with what case? ;) 

As Xan suggested earlier, I've changed this to simply 'webkitgtk'.


> 2. Weird license issue: 
> 
> JavaScriptCore/runtime/DateMath.h has a odd multilicense. 
> I am assuming we are distributing it under LGPLv2+. Should we delete the 
> MPL parts as it suggests? Or do we care? 

My understanding is that we _are_ distributing it under LGPLv2+, but I leave
the other clauses in there so that it is still feasible to re-use that code
under the MPL/GPL's terms, since we're merely redistributing a pristine copy of
the upstream tarball (and not changing anything in it).

> 3. A few items from the build.log: 
> 
> checking whether to enable geolocation support... no
> checking whether to enable WML support... no
> checking whether to enable support for SVG filters... no
> checking whether to enable code coverage support... no
> 

SVG and WML support are included as build-time condtionals (`--with svg' and
`--with wml', respectively). I've also added the code coverage support as a
build conditional in 1.1.4-1 (`--with coverage') and enabled the geolocation
support by default, following upstream's configure script settings.

The new SRPM and spec file are on my webspace:
SRPM: http://projects.thecodergeek.com/for-review/webkitgtk-1.1.4-1.src.rpm
Spec: http://projects.thecodergeek.com/for-review/webkitgtk.spec

Thanks again! :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.