[Bug 489962] Review request: libhbalinux - SNIA HBAAPI vendor library

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489962


Dan Horák <dan at danny.cz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Dan Horák <dan at danny.cz>  2009-04-08 06:21:35 EDT ---
formal review is here, see the notes below:

OK source files match upstream:
     c6461663ae3ca88c3028ee9308add53764fab76b  libhbalinux-1.0.7.tar.gz
OK package meets naming and versioning guidelines.
OK specfile is properly named, is cleanly written and uses macros consistently.
OK dist tag is present.
OK license field matches the actual license.
OK license is open source-compatible (LGPLv2). License text included in
package.
OK latest version is being packaged.
OK BuildRequires are proper.
OK compiler flags are appropriate.
OK %clean is present.
OK package builds in mock (Rawhide/x86_64).
OK debuginfo package looks complete.
OK* rpmlint is silent.
OK final provides and requires look sane.
N/A %check is present and all tests pass.
OK no shared libraries are added to the regular linker search paths.
OK owns the directories it creates.
OK doesn't own any directories it shouldn't.
OK no duplicates in %files.
OK file permissions are appropriate.
OK no scriptlets present.
OK code, not content.
OK documentation is small, so no -docs subpackage is necessary.
OK %docs are not necessary for the proper functioning of the package.
OK no headers.
OK no pkgconfig files.
OK no libtool .la droppings.
OK not a GUI app.

- IMO the ldconfig call is useless, because the library will be dlopened as a
"plugin"
- rpmlint complains a bit
libhbalinux.src: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 44)
 => false positive
libhbalinux.x86_64: E: explicit-lib-dependency libhbaapi
 => the dependency is correct
libhbalinux.x86_64: W: dangerous-command-in-%postun mv
 => can be ignored
libhbalinux.x86_64: E: use-tmp-in-%postun
 => the copy could be created in /etc instead of /tmp

This package is APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.