[Bug 494857] New: Review Request: pidgin-musictracker - Pidgin displays the musictrack currently playing in your status

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.

Summary: Review Request: pidgin-musictracker - Pidgin displays the musictrack currently playing in your status

https://bugzilla.redhat.com/show_bug.cgi?id=494857

           Summary: Review Request: pidgin-musictracker - Pidgin displays
                    the musictrack currently playing in your status
           Product: Fedora
           Version: rawhide
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: medium
          Priority: low
         Component: Package Review
        AssignedTo: nobody at fedoraproject.org
        ReportedBy: jan.klepek at hp.com
         QAContact: extras-qa at fedoraproject.org
                CC: notting at redhat.com, fedora-package-review at redhat.com
   Estimated Hours: 0.0
    Classification: Fedora
    Target Release: ---


Spec URL: http://wwwnick.net/~wwwnick/fedora/pidgin-musictracker.spec
SRPM URL:
http://wwwnick.net/~wwwnick/fedora/pidgin-musictracker-0.4.16-1.fc10.src.rpm

Description: Musictracker is a plugin for Pidgin which displays the media
currently playing in the status message for any protocol Pidgin supports custom
statuses on. 

My package review
#  MUST: rpmlint must be run on every package. 

[makerpm at fetaciq SPECS]$ rpmlint pidgin-musictracker.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[makerpm at fetaciq SPECS]$ rpmlint
../SRPMS/pidgin-musictracker-0.4.16-1.fc10.src.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
[makerpm at fetaciq SPECS]$ rpmlint ../RPMS/
i386/   noarch/ 
[makerpm at fetaciq SPECS]$ rpmlint ../RPMS/i386/pidgin-musictracker-*
pidgin-musictracker-static.i386: W: no-documentation
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

No documentation available for -static package

# MUST: The package must be named according to the Package Naming Guidelines .
- ok

# MUST: The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption.
- OK

# MUST: The package must meet the Packaging Guidelines .
- ok

# MUST: The package must be licensed with a Fedora approved license and meet
the Licensing Guidelines .
- OK

# MUST: The License field in the package spec file must match the actual
license. 
- OK 

# MUST: If (and only if) the source package includes the text of the license(s)
in its own file, then that file, containing the text of the license(s) for the
package must be included in %doc.[4]
- OK

# MUST: The spec file must be written in American English.
- OK

# MUST: The spec file for the package MUST be legible.
- IMHO OK

# MUST: The sources used to build the package must match the upstream source,
as provided in the spec URL. Reviewers should use md5sum for this task. If no
upstream URL can be specified for this package, please see the Source URL
Guidelines for how to deal with this.
- OK

# MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture.

- OK, builded on 
uname -a
Linux fetaciq 2.6.27.21-170.2.56.fc10.i686 #1 SMP Mon Mar 23 23:37:54 EDT 2009
i686 i686 i386 GNU/Linux

# MUST: All build dependencies must be listed in BuildRequires
- OK

# MUST: The spec file MUST handle locales properly. This is done by using the
%find_lang macro. Using %{_datadir}/locale/* is strictly forbidden
- OK

# MUST: Every binary RPM package (or subpackage) which stores shared library
files (not just symlinks) in any of the dynamic linker's default paths, must
call ldconfig in %post and %postun.
- OK

# MUST: If the package is designed to be relocatable, the packager must state
this fact in the request for review, along with the rationalization for
relocation of that specific package. Without this, use of Prefix: /usr is
considered a blocker.

- not relocatable package, OK

# MUST: A package must own all directories that it creates. If it does not
create a directory that it uses, then it should require a package which does
create that directory. 
- OK

# MUST: A Fedora package must not list a file more than once in the spec file's
%files listings.
- OK

# MUST: Permissions on files must be set properly. Executables should be set
with executable permissions, for example. Every %files section must include a
%defattr(...) line. 

- OK, defattr() present

# MUST: Each package must have a %clean section, which contains rm -rf
%{buildroot} (or $RPM_BUILD_ROOT). 

- OK

# MUST: Each package must consistently use macros.
- imho OK

# MUST: The package must contain code, or permissable content.
- ok

# MUST: Large documentation files must go in a -doc subpackage. (The definition
of large is left up to the packager's best judgement, but is not restricted to
size. Large can refer to either size or quantity). 
- OK, no large files present

# MUST: If a package includes something as %doc, it must not affect the runtime
of the application. To summarize: If it is in %doc, the program must run
properly if it is not present. 
- OK

# MUST: Header files must be in a -devel package.
- no header files are installed by make install

# MUST: Static libraries must be in a -static package.
- OK

# MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'
(for directory ownership and usability). 
- OK, no .pc files present

# MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1),
then library files that end in .so (without suffix) must go in a -devel
package. 
- OK

# MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency: Requires: %{name} =
%{version}-%{release}
- No devel package

# MUST: Packages must NOT contain any .la libtool archives, these must be
removed in the spec if they are built.
-OK, removed during %install

# MUST: Packages containing GUI applications must include a %{name}.desktop
file, and that file must be properly installed with desktop-file-install in the 
%install section. 
- not gui

# MUST: Packages must not own files or directories already owned by other
packages. 
- OK

# MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot}
(or $RPM_BUILD_ROOT). 
- OK

# MUST: All filenames in rpm packages must be valid UTF-8.
-OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.