[Bug 494857] Review Request: pidgin-musictracker - Pidgin displays the musictrack currently playing in your status

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494857





--- Comment #1 from Lubomir Rintel <lkundrak at v3.sk>  2009-04-08 08:37:42 EDT ---
1.) Don't disable the debug package

%define debug_package %{nil}

2.) Don't ship static libraries unless necessary
I bet here's no use of it. Probably configure accepts --disable-static

%package static
...

3.) Don't strip debugging information. See 1.)

strip src/.libs/musictracker.so

4.) Please add -f here
...so that short-circuited installs work

rm %{buildroot}/%{_libdir}/pidgin/musictracker.la

5.) You don't need to specify dist tag in changelog
You may want to build a single spec file into multiple branches

* Wed Apr  9 2009 Jan Klepek <jan.klepek at hp.com> 0.4.16-1.fc10

6.) Don't call ldconfig unless you're packaging a library
This DSO is just a plugin, not at the library location

%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.