[Bug 494726] Review Request: Gnote - Note Taking Application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494726


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #12 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-08 10:11:25 EDT ---
(In reply to comment #9)
> This is the infamous Fedora pkg-config problem, where Requires.private in the
> pkgconfig file is evaluated and suffers from a missing dependency on dbus-devel
> (for dbus-1.pc). Normally, BR GConf2-devel would suffice.

I have seen the error message too. Thanks a lot for your explanation and the
hint, Michael.

(In reply to comment #10)
> I didn't do autostart but fixed rest of the issues. 

Ok.

78d037b7591dc016546bc11e34afebd1  gnote-0.1.1-3.fc10.src.rpm
fixes the outstanding issues:
OK - %files
OK - BuildRequires
OK - Requires: desktop-file-utils is not a requirement but a BuildReqiures
OK - Gconf2 for the scriptles:
OK - redundant BuildRequires: libxml2-devel dropped
OK - Using wildcards: %{_datadir}/icons/hicolor/*/apps/gnote.png
OK - Desktop file: --vendor="" removed

Todo:
- Please drop "Requires: gtkmm24" and let rpm pick up the libs automatically.
- %description not ending with a dot.
- If you use "V=1 make %{?_smp_mflags}" you don't need "BuildRequires:
dbus-devel.

These issues are minor and can be fixed after import. This package is

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.