[Bug 226108] Merge Review: lsof

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226108


Michal Nowak <mnowak at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|MODIFIED                    |ASSIGNED
                 CC|                            |mnowak at redhat.com
         AssignedTo|kzak at redhat.com             |mnowak at redhat.com
               Flag|fedora-review-              |fedora-review?,
                   |                            |needinfo?(kzak at redhat.com)




--- Comment #7 from Michal Nowak <mnowak at redhat.com>  2009-04-08 11:06:54 EDT ---
Will do the Merge Review here, let's finish this one.
--

* `upstream2downstream.sh' -- could have license statement

* looks like there's new 4.82 version (not sure whether there are any Linux
related stuff)

* %define lsofrh lsof_4.81-rh -- incorporate %{version} here

* 

[...]
# 184338 - allow lsof access nptl threads
Patch1: lsof_4.81-threads.patch
# 480694 - lsof manpage mismarked and formats badly
Patch2: lsof_4.81-man.patch
[...]
%patch1 -p1
%patch2 -p1
[...]

Patching starts from "Patch0" :)

* Don't mix macro and variable style 
  - $RPM_OPT_FLAGS -> %{optflags}
  - ${RPM_BUILD_ROOT} -> %{buildroot}

* %defattr(644,root,root,755) -> %defattr(-,root,root,-) it's the same and the
later preferred

* %attr(0755,root,root) %{_sbindir}/lsof
`-------^^^^^---(not necessary)

--

The rest looks good.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.