[Bug 226322] Merge Review: psmisc

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226322


Michal Nowak <mnowak at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnowak at redhat.com
               Flag|                            |needinfo?(dnovotny at redhat.c
                   |                            |om)




--- Comment #11 from Michal Nowak <mnowak at redhat.com>  2009-04-08 12:41:51 EDT ---
Daniel, can you please follow up to Jon's proposals?

--

Also:

* Not necessary to define globally when used only for make

  export CFLAGS="$RPM_OPT_FLAGS -D_GNU_SOURCE"

also not sure whether is "-D_GNU_SOURCE" necessary, shouldn't $RPM_OPT_FLAGS
take care of everything?

* don't mix variable and macro style 

https://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

* %defattr(-,root,root)

A little bit old-school to me. Use

  %defattr(-,root,root,-)

* point URL field to http://sourceforge.net/projects/psmisc/ the present one is
useless (bogus content there)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.