[Bug 494171] Review Request: hostapd - WLAN Accesspoint daemon

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=494171


Jon Ciesla <limb at jcomserv.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |limb at jcomserv.net




--- Comment #4 from Jon Ciesla <limb at jcomserv.net>  2009-04-08 15:08:05 EDT ---
Minor nitpick, linked spec and SRPM spec differ. . .

< URL:          http://hostap.epitest.fi/hostapd/      
< # Generate tarball:
< # git clone git://w1.fi/srv/git/hostap.git
< # cd hostap
< # git-archive --format=tar --prefix=hostapd-0.6.9/ %{gitversion} | bzip2 >
hostapd.`date +%Y%m%d`git%{gitversion}.tar.bz2     
---
> URL:          http://hostap.epitest.fi/hostapd/    

I assume the linked one is preferred, and is what my meta-review is of.

Otherwise, a pretty good review, particulart WRT the docs and initscripts.

Re: Macros, %{optflags} and $RPM_BUILD_ROOT have little to do with each other. 
One is a macro and one a variable.  Using each is fine.  What is not
recommended is mixing %{buildroot} and $RPM_BUILD_ROOT, you should pick one.

Upstream patch status would be nice as well.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.