[Bug 489728] Review Request: kcheckers - Checkers board game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489728





--- Comment #6 from Marcin Łabanowski <chax at i-rpg.net>  2009-04-09 07:17:27 EDT ---
> Great, thanks for comments!
You're welcome ;)

> Those are QT locales, they are usually being put in program's share dir, as
done here by upstream.
I see, psi does it the same way, but for example arora puts these under
%{_datadir}/%{name}/locale . Well, if other packages can keep it just under
%{_datadir}/%{name}, I assume it's ok.

> This is qmake, not cmake.
Uhm, I was mistaken. Anyway, using optflags is a must, so please try at least:
CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" make %{?_smp_mflags}

> Um, why not OK?
You didn't build as a separate user. While it is not necessary to build a
correct package, this point is a part of the guidelines. And I noticed, that
the SRPMS preserved ownership of an account which was named "alex", which I
didn't suppose to be a separate account ;).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.