[Bug 226342] Merge Review: python

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226342


Michal Nowak <mnowak at redhat.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |mnowak at redhat.com
         AssignedTo|nobody at fedoraproject.org    |mnowak at redhat.com
               Flag|                            |fedora-review?,
                   |                            |needinfo?(james.antill at redh
                   |                            |at.com)




--- Comment #8 from Michal Nowak <mnowak at redhat.com>  2009-04-09 07:32:25 EDT ---
* mostly missing state of the patches w.r.t. upstream

> Patch0: python-2.6-config.patch
> Patch1: Python-2.2.1-pydocnogui.patch

https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment

* inconsistency in sub-packages "Requires" field:

- python-libs : Requires: %{python} = %{version}-%{release}
- python-tools: Requires: %{name} = %{version}-%{release}

in case it's expected to be %{python} -eq %{name} I'd prefer to land on %{name}
here.

* inconsistency in patching

> %patch6 -p1 -b .plural
> %patch7 -p1

* old-school exec, back-ticks are BASH specific and non-POSIX, even in Python
are now discouraged

topdir=`pwd`  ->  topdir=$(pwd)

* missing _"_ should cover LD_LIBRARY_PATH's value

- LD_LIBRARY_PATH=$topdir $topdir/python Tools/scripts/pathfix.py -i
"%{_bindir}/env python%{pybasever}" .

- LD_LIBRARY_PATH=$topdir PATH=$PATH:$topdir make -s OPT="$CFLAGS"
%{?_smp_mflags}

- make install DESTDIR=$RPM_BUILD_ROOT

* from what is this preventing? Considering that this is the only occurrence.

[ -d $RPM_BUILD_ROOT ] && rm -fr $RPM_BUILD_ROOT
^^^^^^^^^^^^^^^^^^^^^^

* using path-based BR is discouraged /usr/bin/find, use "findutils" better, but
note, that are listed in packages not necessary to be pulled to BR's
https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions and thus always
expected to be present.

* BuildRoot is non-standard, use one of this ones:
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag

> BuildRoot: %{_tmppath}/%{name}-%{version}-root

* is this hard-coded "/usr" necessary?

mkdir -p $RPM_BUILD_ROOT/usr $RPM_BUILD_ROOT%{_mandir}

  -> 

mkdir -p $RPM_BUILD_ROOT%{_prefix} $RPM_BUILD_ROOT%{_mandir}

* don't mix variable and macro style (e.g. $RPM_BUILD_ROOT -> %{buildroot})

https://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

* old-school defattr

%defattr(-, root, root) -> %defattr(-,root,root,-)

* be consistent with

  %dir %{_libdir}/python%{pybasever}
  %dir %{_libdir}/python%{pybasever}/site-packages

where when %{_prefix} is changed then %{_libdir} is changed too:

"""
%if "%{_lib}" == "lib64"
%attr(0755,root,root) %dir /usr/lib/python%{pybasever}
%attr(0755,root,root) %dir /usr/lib/python%{pybasever}/site-packages
%endif
"""

  ->

"""
%if "%{_lib}" == "lib64"
%dir %{_prefix}/lib/python%{pybasever}
%dir %{_prefix}/lib/python%{pybasever}/site-packages
%endif
"""

* hard-coded includedir

/usr/include/* -> %{_includedir}/%{name}%{pybasever}

* %defattr(-,root,root,755) -> %defattr(-,root,root,-)

* RPMLINT:

- python.x86_64: W: obsolete-not-provided python-elementtree

python-elementtree still present in F-9 and devel

- python.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/python
2.6/lib-dynload/_sqlite3.so ['/usr/lib64']

https://fedoraproject.org/wiki/Packaging:Guidelines#Beware_of_Rpath

- python.x86_64: E: non-standard-executable-perm /usr/lib64/python2
.6/lib-dynload/_ssl.so 0555

[and a lot of others] should be 0755?

- python.x86_64: E: script-without-shebang /usr/lib64/python2.6/run
py.py

Add shebang, or remove exec perm.

- python-devel.x86_64: W: summary-ended-with-dot The libraries and 
header files needed for Python development.
- python-tools.x86_64: W: summary-ended-with-dot A collection of de
velopment tools included with Python.

Fix, please.

- python-test.x86_64: W: spelling-error-in-description pacakge pack
age

ditto

- python-test.x86_64: W: no-documentation

Ignore, perhaps...

- python-test.x86_64: E: non-executable-script /usr/lib64/python2.6
/test/test_multibytecodec_support.py 0644

Add 0755 perms, or remove shebang.

- python-test.x86_64: E: zero-length /usr/lib64/python2.6/test/null
cert.pem

Is it necessary for the test?

- python-test.x86_64: E: wrong-script-interpreter /usr/lib64/python
2.6/test/test_pep263.py "-*-"

rpmlint is confused here because of the leading _!_, which is hardly necessary
there, MacCVS should be fixed, not that file.

- python-test.x86_64: E: wrong-script-end-of-line-encoding /usr/lib
64/python2.6/test/test_pep263.py

- python-tools.x86_64: W: devel-file-in-non-devel-package /usr/lib6
4/python2.6/Demo/embed/demo.c

Probably not necessary to create python-tools-devel for two tests/4 .c files.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.