[Bug 489728] Review Request: kcheckers - Checkers board game

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=489728





--- Comment #8 from Alexey Torkhov <atorkhov at gmail.com>  2009-04-09 10:06:12 EDT ---
(In reply to comment #6)
> > This is qmake, not cmake.
> Uhm, I was mistaken. Anyway, using optflags is a must, so please try at least:
> CFLAGS="%{optflags}" CXXFLAGS="%{optflags}" make %{?_smp_mflags}

The CFLAGS and CXXFLAGS are usually set by rpm itself. Some mangling with
optflags is needed when some build system is doesn't respect them properly. You
can check that optflags are actually used when building.
(Get optflags with "rpm -E %optflags" and look that it exist in build log)

> > Um, why not OK?
> You didn't build as a separate user. While it is not necessary to build a
> correct package, this point is a part of the guidelines. And I noticed, that
> the SRPMS preserved ownership of an account which was named "alex", which I
> didn't suppose to be a separate account ;).  

Ah, you are talking about this:
https://fedoraproject.org/wiki/Packaging/Guidelines#Build_packages_with_separate_user_accounts

Well, you're definitely right. I usually do builds in mock, but not in this
case :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.