[Bug 490269] Review Request: xfglenses - Gravitational lenses visualization program

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=490269





--- Comment #4 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-04-09 19:08:20 EDT ---
rpmlint output:
xfglenses.x86_64: W: incoherent-version-in-changelog 1-0-2 ['1.0-2.fc10',
'1.0-2']
3 packages and 0 specfiles checked; 0 errors, 1 warnings.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK

MUST: The spec file for the package is legible and macros are used
consistently. OK
- The BuildRequires line is a bit long, you could chop it up in two.

MUST: The License field in the package spec file must match the actual license.
OK
- Source code files contain no license headers, please ask upstream to add
them.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. NEEDSFIX
- Source URL gives 404, according to URL correct file is
http://www.tat.physik.uni-tuebingen.de/~frutto/xfglenses.zip
- Source used does not match upstream.

MUST: Optflags are used and time stamps preserved. ???
- No compiler commands are visible in the output.

MUST: Desktop files are installed properly. ??
- If the program starts just by calling the binary, then a Desktop file should
be written.

MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: The spec file MUST handle locales properly. OK
MUST: Packages containing shared library files must call ldconfig. OK
MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: Header files must be in a -devel package. OK
MUST: Static libraries must be in a -static package. OK
MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig'. OK
MUST: If a package contains library files with a suffix then library files
ending in .so must go in a -devel package. OK
MUST: In the vast majority of cases, devel packages must require the base
package using a fully versioned dependency. OK
MUST: Packages does not contain any .la libtool archives. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release.
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.