[Bug 495246] Review Request: perl-POE-Test-Loops - Reusable tests for POE::Loop authors

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495246


Iain Arnell <iarnell at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Iain Arnell <iarnell at gmail.com>  2009-04-11 00:50:15 EDT ---
+ source files match upstream.  
  85a7b805542ecfae32cec5319a3d4eb8f44e1fd1  POE-Test-Loops-1.005.tar.gz

+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ summary is OK.
+ description is OK.
+ dist tag is present.
+ build root is OK.
+ license field matches the actual license.
  GPL+ or Artistic

+ license is open source-compatible.
+ license text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package builds in mock
  http://koji.fedoraproject.org/koji/taskinfo?taskID=1289744

+ package installs properly.
+ rpmlint has no complaints:
  perl-POE-Test-Loops.src: I: checking
  perl-POE-Test-Loops.noarch: I: checking
  2 packages and 0 specfiles checked; 0 errors, 0 warnings.

+ final provides and requires are sane:
  perl(POE::Test::DondeEstan)  
  perl(POE::Test::Loops) = 1.005
  perl-POE-Test-Loops = 1.005-1.fc11
=
  /usr/bin/perl  
  perl(:MODULE_COMPAT_5.10.0)  
  perl(File::Find)  
  perl(File::Path)  
  perl(File::Spec)  
  perl(Getopt::Long)  
  perl(IO::File)  
  perl(IO::Socket)  
  perl(IO::Socket::INET)  
  perl(POE)  
  perl(POE::NFA)  
  perl(POE::Session)  
  perl(POE::Test::DondeEstan)  
  perl(POE::Test::Loops)  
  perl(POSIX)  
  perl(Socket)  
  perl(Symbol)  
  perl(Test::More)  
  perl(lib)  
  perl(strict)  
  perl(vars)  
  perl(warnings)  
  rpmlib(CompressedFileNames) <= 3.0.4-1
  rpmlib(FileDigests) <= 4.6.0-1
  rpmlib(PayloadFilesHavePrefix) <= 4.0-1
  rpmlib(VersionedDependencies) <= 3.0.3-1

+ %check is present and all tests pass.
  All tests successful.
  Files=1, Tests=1,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.06 cusr  0.00
csys =  0.10 CPU)
  Result: PASS

+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no generically named files
+ code, not content.
+ documentation is small, so no -doc subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.


APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.