[Bug 495357] Review Request: python-twill - Simple scripting language for Web browsing

bugzilla at redhat.com bugzilla at redhat.com
Sun Apr 12 17:26:38 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495357





--- Comment #2 from Matthias Saou <matthias at rpmforge.net>  2009-04-12 13:26:38 EDT ---
I've removed the unused pyver, used %global instead of %define.
The patch did have a comment, but above the %patch0 line instead of the Patch0:
one. I've moved it. The logic here is simple : Upstream bundles a bunch of 3rd
party python code to make things easier for end users, but we happen to already
have them available as packages, so what the patch does is use the package
provided code instead of the "internal" forked code. Definitely not worth
reporting upstream.

I've searched the wiki for the guideline about this, as I'm pretty sure there
is one about always using a system wide library instead of a project-provided
local version, but I've been unable to find it.

Thanks for your comments, I've updated the spec and package (didn't bother
bumping the release just for that, though).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list