[Bug 495336] Review Request: perl-Sort-Key - Fastest way to sort anything in Perl

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495336





--- Comment #1 from Chris Weyl <cweyl at alumni.drew.edu>  2009-04-12 13:39:48 EDT ---
I'd put the .so filtering bits before %description as (IMHO) it makes things
look a touch cleaner, but having it where it is isn't a real issue.

koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=1291779

Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic);
make test passes cleanly.

Source tarballs match upstream (sha1sum):
7b50c2a384a817c400d43835638ae5b99b4b217b Sort-Key-1.28.tar.gz
7b50c2a384a817c400d43835638ae5b99b4b217b Sort-Key-1.28.tar.gz.srpm

Final provides / requires are sane:

0 packages and 1 specfiles checked; 0 errors, 0 warnings.
=====> perl-Sort-Key-1.28-1.fc10.src.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Sort-Key-1.28-1.fc10.src.rpm
====> requires for perl-Sort-Key-1.28-1.fc10.src.rpm
perl(ExtUtils::MakeMaker)  
perl(Test::More) >= 0.54

=====> perl-Sort-Key-1.28-1.fc10.x86_64.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Sort-Key-1.28-1.fc10.x86_64.rpm
perl(Sort::Key) = 1.28
perl(Sort::Key::Maker) = 0.02
perl(Sort::Key::Multi) = 1.25
perl(Sort::Key::Natural) = 0.03
perl(Sort::Key::Register) = 0.14
perl-Sort-Key = 1.28-1.fc10
perl-Sort-Key(x86-64) = 1.28-1.fc10
====> requires for perl-Sort-Key-1.28-1.fc10.x86_64.rpm
perl(:MODULE_COMPAT_5.10.0)  
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
perl >= 0:5.006
perl(Carp)  
perl(constant)  
perl(Exporter)  
perl(Sort::Key)  
perl(Sort::Key::Maker)  
perl(Sort::Key::Register)  
perl(strict)  
perl(warnings)  
rtld(GNU_HASH)  

=====> perl-Sort-Key-debuginfo-1.28-1.fc10.x86_64.rpm <=====
====> rpmlint
1 packages and 0 specfiles checked; 0 errors, 0 warnings.
====> provides for perl-Sort-Key-debuginfo-1.28-1.fc10.x86_64.rpm
perl-Sort-Key-debuginfo = 1.28-1.fc10
perl-Sort-Key-debuginfo(x86-64) = 1.28-1.fc10
====> requires for perl-Sort-Key-debuginfo-1.28-1.fc10.x86_64.rpm

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.