[Bug 495440] Review Request: perl-Devel-FastProf - Fast perl per-line profiler

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495440


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-04-13 03:52:10 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1293584
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
f8185d084e0323b96ad69fc24775aa94  Devel-FastProf-0.08.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=5,  0 wallclock secs ( 0.03 usr  0.01 sys +  0.11 cusr  0.02
csys =  0.17 CPU)
+ Package perl-Devel-FastProf-0.08-1.fc11.i586 =>
  Provides: perl(Devel::FastProf) = 0.08 perl(Devel::FastProf::Reader) = 0.08
  Requires: libc.so.6 libc.so.6(GLIBC_2.0) libc.so.6(GLIBC_2.1)
libc.so.6(GLIBC_2.1.3) libc.so.6(GLIBC_2.4) perl(Carp)
perl(Devel::FastProf::Reader) perl(Exporter) perl(Getopt::Std) perl(Sort::Key)
perl(strict) perl(warnings) perl(XSLoader) rpmlib(VersionedDependencies) <=
3.0.3-1 rtld(GNU_HASH) /usr/bin/perl

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.