[Bug 495411] Review Request: dnsjava - Java DNS implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495411





--- Comment #2 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-04-13 14:27:01 EDT ---
(In reply to comment #1)
> * Package does not obey
>     - the "BuildRequires and Requires" section,
[Build]Requires added.

>     - the GCJ section,
I add it. It is new for me, please check wht I do it properly.

>     - the Javadoc scriptlets section of
Ok. ghost deleted.
>   http://fedoraproject.org/wiki/Packaging/Java
> 
> Other than this,
> 
> * Macros must start with %% in the comments and in the changelog.
Off course! Where I do not double it???

> * We prefer %defattr(-,root,root,-)
Ok.

> ? The %section macro is not used. Why is it defined?
It come from JPackage imported rpm. Deleted.


http://hubbitus.net.ru/rpm/Fedora9/dnsjava/dnsjava-2.0.6-2.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.