[Bug 493236] Review Request: xmlfy - Convert text/UTF-8 based output into XML format

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493236





--- Comment #5 from arthurguru <arthurg.work at gmail.com>  2009-04-13 20:33:01 EDT ---
Thanks for the feedback Jan.

1] Timestamps are now preserved.

2] Which "Source" are you referring to, the SRPM or the upstream source file
xmlfy-1.4.2-src.tar.gz? If you use the upstream source the build will fail at
the packaging - I use another top level Makefile "Makefile_src_archive" to
build the source archives including the SRPM. When I build from the SRPM it
works for me, perhaps it could be the path issue that you refer to in point 3.

3] Path references in %install section have now been standardized.
FYI: In the SRPM source the "make all" in the %build section also runs a
package "stage" target which is also the build's own workspace. These package
dir references have now been taken out of the spec file and replaced with a
DESTDIR option making the spec file look more standard.

Once again I’ve updated the files with the same names as to not break the links
in the original post.

Tested ok, rpmlint is still content.

Looking forward to your feedback.

Kind regards,
Arthur Gouros.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.