[Bug 492396] Review Request:php-feedcreator - Create RSS feeds

bugzilla at redhat.com bugzilla at redhat.com
Tue Apr 14 17:02:13 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492396





--- Comment #6 from Xavier Bachelot <xavier at bachelot.org>  2009-04-14 13:02:12 EDT ---
(In reply to comment #5)
> ok great. Let's see if we can move this forward. 
> 
> As noted on bug 492395, it seems that you can just require php-common because
> it requires php.
> 
Or the other way round, just require php. That's what I've done on my local
copy.

> Then, I am not sure if there are guidelines against it, but installing the file
> in {datadir}/php is probably not a wise idea. What about putting it in a
> subdirectory (for example feedcreator would do). In that case, please remember
> to let the package own the directory.

Not sure what's best here. As this is only one file, I think it's ok to let it
at the root of the php include dir. And anyway, looking at the pear include
dir, I see that's what is done : /usr/share/pear/someclass.php, then a
/usr/share/pear/someclass subdir with everything else. That's what I've done
for php-geshi (https://bugzilla.redhat.com/show_bug.cgi?id=492395).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list