[Bug 488995] Review Request: pidgin-tlen - Tlen IM Pidgin plugin

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=488995


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fedora at christoph-wickert.de




--- Comment #4 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-14 13:50:50 EDT ---
(In reply to comment #2)
> (In reply to comment #1)
> > %defattr(644,root,root,755)
> > please use %defattr(-,root,root,-)
> 
> Why?

Because it's both in the packaging and the review guidelines.
http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions

> > makro couples 
> > please use:
> > $RPM_OPT_FLAGS and $RPM_BUILD_ROOT
> > or
> > %{buildroot} and %{optflags}
> > please use one of this couples, but do not mix this.
> 
> You're picky, but OK.

No he's not, it's also part of the guidelines:
http://fedoraproject.org/wiki/Packaging/Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.