[Bug 495001] Review Request: bareftp - File transfer client supporting the FTP, FTP over SSL/TLS (FTPS) and SSH File Transfer Protocol (SFTP)

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495001





--- Comment #6 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-14 14:32:14 EDT ---
(In reply to comment #1)
> --missing Rs
> hicolor-icon-theme

Nope, hicolor-icon-theme doesn't need to be specified explicitly, because we
already have a valid dependency chain: bareftp -> gtk-sharp2 -> gtk ->
hicolor-icon-theme

> --- macros
> please use name macro instead of name

No need to use macros everywhere, just where it makes sense.

> --- permissions
> executing of *.dll is not necessary (didn't check this)

Not sure about this, this could cause an debuginfo package. BTW: have you tried 
  make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" STRIP="/bin/true"?
Just a shot in the dark, didn't check this ether.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.