[Bug 495411] Review Request: dnsjava - Java DNS implementation

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495411





--- Comment #8 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan at hubbitus.info>  2009-04-15 17:09:05 EDT ---
> I guess it is. Putting
>    iconv -f iso8859-1 -t utf8 Changelog > tmpfile
>    touch -r  Changelog tmpfile
>    mv -f tmpfile Changelog
> into %prep solved the issue for me.
Guess from what?? Using iso8859-15 give the same result. And any other 8-bit
encoding may be on this place.
"Ville Skyttä" is right family how you think?


> I think this is my bad. I should've tested this before I spoke in the first
> place. Yes, if GCJ (which supports only up to java 1.5) doesn't build the jar
> file properly, it doesn't make sense to build the aot bits.
Everyone has the right to make a mistake. No problem. I delete this bits.

> > And what is more strange: This package builded fine on my local machine, but
> > failed in koji (http://koji.fedoraproject.org/koji/taskinfo?taskID=1299756) on
> > %check stage. May be internet connection not available in mock chroot??
> > Any suggestions?
> > 
> > http://hubbitus.net.ru/rpm/Fedora9/dnsjava/dnsjava-2.0.6-4.fc9.src.rpm  
> 
> Another thing I should have tested. Koji disables internet connection during
> package building, which is a good thing. Since we do need a connection for
> these tests, it doesn't make sense to run these tests during a standard build
> on koji.
> 
> But I think we should keep the code there and comment it out (or put an 
>    %if do_test
>    %check
>    <code>
>    %endif
> clause around it and disable the tests on top of the SPEC file via
>    %global do_test 0
> ). In either case, we need to explain in the SPEC file why we disabled them by
> default.  
I think the same. Done.

http://hubbitus.net.ru/rpm/Fedora9/dnsjava/dnsjava-2.0.6-5.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.