[Bug 483543] Review Request: systemtapguiserver

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=483543


Lubomir Rintel <lkundrak at v3.sk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #20 from Lubomir Rintel <lkundrak at v3.sk>  2009-04-16 04:03:56 EDT ---
* Wed Apr 15 2009 Anithra P Janakiraman <anithra at linux.vnet.ibm.com> 1.0-7
- Changes to spec file.

Anithra, this is the extreme example of poorly written changelog entry. When
writing change log entries, describe what you changed, such as:

- Don't strip binary anymore
- Correct the file modes
...

Anyways, not anything that would block the review.

- compiler flags used correctly
- spec file clean, legible, using American english
- filelist sane
- builds fine in mock
- requires fine
- provides fine
- builds in mock
- rpmlint happy

The package is

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.