[Bug 493750] Review Request: netcf - a library for managing network configuration

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=493750


Michael Schwendt <bugs.michael at gmx.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #5 from Michael Schwendt <bugs.michael at gmx.net>  2009-04-16 07:18:45 EDT ---
Okay, packaging-wise the 0.0.2-1.fc10 src.rpm is fine:

  APPROVED

[...]

The remaining minor issues are within your upstream tarball:

* Duplicated CFLAGS. Quoting from:
http://koji.fedoraproject.org/koji/getfile?taskID=1300747&name=build.log

>>>
make[3]: Entering directory `/builddir/build/BUILD/netcf-0.0.2/src'
/bin/sh ../libtool --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..   
--std=gnu99 -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables
-I ../gnulib/lib -Wall -Wformat -Wformat-security -Wmissing-prototypes
-Wnested-externs -Wpointer-arith -Wextra -Wshadow -Wcast-align -Wwrite-strings
-Waggregate-return -Wstrict-prototypes -Winline -Wredundant-decls
-Wno-sign-compare -I/usr/include/libxml2   -I/usr/include/libxml2   -O2 -g
-pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector
--param=ssp-buffer-size=4 -m32 -march=i586 -mtune=generic
-fasynchronous-unwind-tables -MT netcf.lo -MD -MP -MF .deps/netcf.Tpo -c -o
netcf.lo netcf.c
<<<

Actually, it's _not_ duplicated CFLAGS as it seemed first, but that you
AC_SUBST default NETCF_CFLAGS in the configure script (precisely:
-Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fasynchronous-unwind-tables), which are
added a second time with Fedora's global optflags. I've expected Fedora's
CFLAGS to override the defaults except for a hardcoded -fexceptions (which you
want for interoperability with netcf API users written in C++).


* pkgconfig file issues. The result of adding the "Requires" to the .pc file is
this:

$ pkg-config --cflags netcf
-I/usr/include/libxml2

$ pkg-config --libs netcf
-lnetcf -laugeas -lxslt -lz -lm -lxml2  

This is not needed for shared linking (the default with Fedora), because you
don't need all those libs and headers when building with the libnetcf API. You
only need them when linking statically (comment 2), and then you would prefer
"Requires.private" and "Libs.private" and "pkg-config --static ...". The
current pkgconfig inter-package dependencies lead to dependency-bloat.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.