[Bug 491566] Review Request: powwow - A console MUD client

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=491566





--- Comment #7 from Thomas Sailer <t.sailer at alumni.ethz.ch>  2009-04-17 10:03:13 EDT ---
Fedora review powwow-1.2.14-2.fc11.src.rpm 2008-04-17

Scratch build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=1304042

+ OK
! needs attention

+ rpmlint output
+ Package is named according to Fedora Package Naming Guidelines
+ Specfile name matches the package base name
+ Package follows the Fedora packaging guidelines
+ License meets guidelines and is acceptable to Fedora
  GPLv2+
+ License matches the actual package license
+ The package contains the license file (COPYING)
+ Spec file is written in American English
+ Spec file is legible
+ Upstream sources match sources in the srpm
5c1d600ca8e577dc620c1c15c01cfdf5  ../SOURCES/powwow-1.2.14.tar.gz
5c1d600ca8e577dc620c1c15c01cfdf5  powwow-1.2.14.tar.gz

n/a Package builds in mock
n/a ExcludeArch bugs filed
+ BuildRequires list all build dependencies
n/a %find_lang instead of %{_datadir}/locale/*
n/a binary RPM with shared library files must call ldconfig in %post and
%postun
+ Does not use Prefix: /usr
+ Package owns all directories it creates
+ No duplicate files in %files
+ %files has %defattr
+ %clean contains rm -rf $RPM_BUILD_ROOT
+ Consistent use of macros
+ Package must contain code or permissible content
n/a Large documentation files should go in -doc subpackage
+ Files marked %doc should not affect package
+ Header files should be in -devel
n/a Static libraries should be in -static
n/a Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'
n/a libfoo.so must go in -devel
n/a -devel must require the fully versioned base
n/a Packages should not contain libtool .la files
n/a Packages containing GUI apps must include %{name}.desktop file
+ Packages must not own files or directories owned by other packages
+ %install begins with rm -rf $RPM_BUILD_ROOT
+ Filenames must be valid UTF-8

Now some general comments:
- Filenames like "muc", "follow", and "movie_play" seem to be fairly generic
and thus prone to conflicts in the future; they do not seem to conflict now
- follow is described by the accompanying documentation as mainly a debugging
aid - should this really be packaged, in the main package?
- what is the use case for the -devel package? It contains only header files,
no actual lib

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.