[Bug 492773] Review Request: camcardsync - tool for copying photos from a camera card

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492773





--- Comment #3 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-04-18 14:04:54 EDT ---
Created an attachment (id=340167)
 --> (https://bugzilla.redhat.com/attachment.cgi?id=340167)
Patch to compile with g++44

Some notes:

* Summary
  - Including the name of the package into Summary

* License
  - For this package the license tag should be GPLv2+.

* BR
  - "BuildRequires: glib2-devel" is redundant because
    gtk2-devel requires glib2-devel

  - build.log says:
---------------------------------------------------------
   225  checking for HAL... no
---------------------------------------------------------
    It seems this can be enabled by "BR: hal-devel".

* %description
  - I don't think including sentences like
---------------------------------------------------------
* My camera has a 2GB card and thus will frequently contain 
  photographs spanning several weeks, or even months.
---------------------------------------------------------
    or so is proper, because these sentences look
    like personal comments or so.

* Build failure
  - This package does not build on dist-f11-updates-candidate
    (with g++44). The attached patch is needed.

* scriplets
  - Please update GTK icon cache related scripts:
    https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Icon_Cache

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.