[Bug 477948] Review Request: simple-ccsm - Simplified plugin and configuration tool - Compiz Fusion Project

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=477948


Fabian Affolter <fabian at bernewireless.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |fabian at bernewireless.net




--- Comment #1 from Fabian Affolter <fabian at bernewireless.net>  2009-04-20 03:45:08 EDT ---
Just some quick comments on your spec file.  I did only a 'look-at-it' review.

- License is GPLv2+ (or (at your option) any later version) not GPLv2. 
Mentioned in the LICENSE file and the source header.  PKG-INFO says GPL. 
- Is there no URL for Source0? If not, can you please describe the generation
of the source tarball as mentioned in the guidelines.
- Isn't 'BR: gettext' a duplicate?  'intltool' requires 'gettext' already.
- INSTALL says '...depends on Python and PyGTK'.  
- Isn't 'Requires: hicolor-icon-theme' is missing?
- '--vendor="fedora"' is no longer needed for new packages
  https://fedoraproject.org/wiki/Packaging:Guidelines#Desktop_files

Version 0.8.3 was released some weeks ago.
http://gitweb.compiz-fusion.org/?p=compiz/compizconfig/ccsm;a=commit;h=2deb7e7194ddae144c98ea2cbef7e40f2d468b33

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.