[Bug 496606] Review Request: perl-Log-LogLite - Create simple logs

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496606





--- Comment #1 from Jussi Lehtola <jussi.lehtola at iki.fi>  2009-04-20 16:20:02 EDT ---
rpmlint output is clean.

Provides are sane:
perl(Log::LogLite) = 0.82
perl(Log::NullLogLite) = 0.82
perl-Log-LogLite = 0.82-1.fc10

Requires:
perl(:MODULE_COMPAT_5.10.0)  
perl(Carp)  
perl(IO::LockedFile) >= 0.21
perl(Log::LogLite)  
perl(strict)  
perl(vars)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK

MUST: The License field in the package spec file must match the actual license.
NEEDSFIX
- According to README:
   This package is free software; you can redistribute it and/or 
   modify it under the same terms as Perl itself.
- License of Perl is: (GPL+ or Artistic) and (GPLv2+ or Artistic)
- Please contact upstream and ask them to clarify license.

MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: Optflags are used and time stamps preserved. OK

MUST: A package must own all directories that it creates or require the package
that owns the directory. OK
/usr/lib/perl5/vendor_perl/5.10.0/Log
/usr/lib/perl5/vendor_perl/5.10.0/Log/LogLite.pm
/usr/lib/perl5/vendor_perl/5.10.0/Log/NullLogLite.pm
/usr/share/doc/perl-Log-LogLite-0.82
/usr/share/doc/perl-Log-LogLite-0.82/Changes
/usr/share/doc/perl-Log-LogLite-0.82/README
/usr/share/man/man3/Log::LogLite.3pm.gz
/usr/share/man/man3/Log::NullLogLite.3pm.gz

MUST: Files only listed once in %files listings. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK
SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. OK
SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.