[Bug 492231] Review Request: trac-watchlist-plugin - plugin for watching trac wiki pages and tickets

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=492231


Till Maas <opensource at till.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
         AssignedTo|nobody at fedoraproject.org    |opensource at till.name
               Flag|                            |fedora-review+




--- Comment #4 from Till Maas <opensource at till.name>  2009-04-21 13:51:59 EDT ---
[OK] rpmlint output:
trac-watchlist-plugin.noarch: W: no-documentation

[OK] Spec in %{name}.spec format

[OK] license allowed: BSD
[OK] license matches shortname in License: tag
[OK] license in tarball and included in %doc: not in upstream tarball/SCM

[OK] package is code or permissive content:
{OK} patches sent to upstream and commented: no patches

[GOOD ENOUGH] Source0 is a working URL
Tarball generation instructions work

{N/A} Sourceforge URL is Source0:
http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.gz
https://fedoraproject.org/wiki/Packaging/SourceURL#Sourceforge.net
<OK> SourceX / PatchY prefixed with %{name}


[OK] Source0 matches Upstream:
indidual files in tarball match locally generated tarball

[OK] Package builds on all primary architectures: noarch
http://koji.fedoraproject.org/koji/taskinfo?taskID=1311889
[N/A] ExcludeArch bugs are filed and commented:
[OK] BuildRequires are complete (mock builds)
(OK) No file dependencies outside of /etc /bin /sbin /usr/bin /usr/sbin 

[N/A] %find_lang used for locales

[N/A] Every (sub)package containing libraries runs ldconfig
%post -p /sbin/ldconfig
%postun -p /sbin/ldconfig
[N/A] .h (header) files are in -devel subpackage
[N/A] .a (static libraries) are in -static subpackage
[N/A] contains .pc (pkgconfig) files and has Requires: pkgconfig
(N/A) .pc files are in -devel subpackage
[N/A] contains .so.X(.Y) files and .so is in -devel
[N/A] -devel subpackage has Requires: %{name} = %{version}-%{release}
[N/A] .la files (libtool) are not included


[N/A] Has GUI and includes %{name}.desktop
[N/A] Follows desktop entry spec
[N/A] Valid .desktop Name
[N/A] Valid .desktop GenericName
[N/A] Valid .desktop Categories

[N/A] Valid .desktop StartupNotify
[N/A] .desktop file installed with desktop-file-install in %install

[OK] Prefix: /usr not used (not relocatable)

[OK] Owns all created directories
[OK] no duplicates in %files
[OK] %defattr(-,root,root,-) is in every %files section
[OK] Does not own files or dirs from other packages
[OK] included filenames are in UTF-8

[OK] %clean is rm -rf %{buildroot} or $RPM_BUILD_ROOT 
[OK] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT 

[OK] Consistent macro usage
[OK] large documentation is -doc subpackage
[OK] %doc does not affect runtime

{OK} no pre-built binaries (.a, .so*, executable)
{OK} well known BuildRoot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)

{OK} PreReq not used
{N/A} RPM_OPT_FLAGS honoured
{N/A} Useful debuginfo generated
{OK} no duplication of system libraries
{OK} no rpath
{GOOD ENOUGH} Timestamps preserved with cp and install
{N/A} Uses parallel make (%{?_smp_mflags})
{OK} Requires(pre,post) style notation not used
{OK} only writes to tmp /var/tmp $TMPDIR %{_tmppath} %{_builddir} (and
%{buildroot} on %install and %clean)
{OK} no Conflicts
{OK} nothing installed in /srv
{OK} Changelog in allowed format
{OK} does not use Scriptlets
<OK> Architecture independent packages have: BuildArch: noarch
<OK> Sane Provides: and Requires:
{OK} Follows Naming Guidelines
{OK} Has BuildRequires: python
{NOT OK} Defines and uses %{python_sitelib}:
%{!?python_sitelib: %global python_sitelib %(%{__python} -c "from
distutils.sysconfig import get_python_lib; print get_python_lib()")}
you should use %global instead of %define

[OK] Python eggs must be built from source. They cannot simply drop an egg from
upstream into the proper directory.
[OK] Python eggs must not download any dependencies during the build process.
[OK] If egg-info files are generated by the modules build scripts they must be
included in the package.
[N/A] When building a compat package, it must install using easy_install -m so
it won't conflict with the main package.
[N/A] When building multiple versions (for a compat package) one of the
packages must contain a default version that is usable via "import MODULE" with
no prior setup.
(OK) A package which is used by another package via an egg interface should
provide egg info. 

{OK} Egg install:
%install
%{__python} setup.py install --skip-build --root $RPM_BUILD_ROOT 


Please change the two occurences of %define to %global before importing the
package into Fedora. Except for this minor issue the package looks good and is
therefore APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.