[Bug 495412] Review Request: flamerobin - Graphical client for Firebird

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495412





--- Comment #8 from Mamoru Tasaka <mtasaka at ioa.s.u-tokyo.ac.jp>  2009-04-22 10:25:03 EDT ---
Notes:

On my system _iconsdir or so is defined, however
-------------------------------------------------------
[tasaka1 at localhost ~]$ grep %_iconsdir /etc/rpm/macros.*
/etc/rpm/macros.jpackage:%_iconsdir %{_datadir}/icons
[tasaka1 at localhost ~]$ grep -l %_iconsdir /etc/rpm/macros.* | xargs rpm -qf
jpackage-utils-1.7.5-2.7.fc11.noarch
-------------------------------------------------------
i.e. only when jpackage-utils (Java related package) is installed,
     these macros can be used.
So if you want to use macros such as _iconsdir, 
"BuildRequires: jpackage-utils" is needed to make it sure that
%_sysconfdir/rpm/macros.jpackage surely exists.

However
- This package does not seem to be related to Java
- So adding "BR: jpackage-utils" just to define %_iconsdir or
  so is not desired
- Also almost all packages on Fedora installing files under
  %_datadir/icons/ use %_datadir/icons, not %_iconsdir

So replacing %_iconsdir with %_datadir/icons is much preferable.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.