[Bug 496492] Review Request: sing - Sends fully customized ICMP packets from command line

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496492


Christoph Wickert <fedora at christoph-wickert.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #6 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-22 19:15:59 EDT ---
Ok, now that the update got pushed mockbuilds work for me, even in the wannabe
rawhide mock that turned out to be F11.

(In reply to comment #4)
> Local build fails if too many autotool versions are installed in parallel,
> but a successful local build never have been a must, haven't it?

http://fedoraproject.org/wiki/Packaging/ReviewGuidelines#cite_ref-6
"MUST: The package MUST successfully compile and build into binary rpms on at
least one primary architecture."
IMO this also includes local builds. Anyway, the package must no break if more
than one version of autotool is installed. How about:

  for file in %{_datadir}/automake-*/config.*; do
      cp -f $file .
  done

Works fine here.

> De-macrofying the URL tag is possible, if that makes you happy. Other issue
> as well as notes are minor so far to me, right?  

Yes, they are minor non-blockers, but that doesn't mean the package can't be
improved, right?

The outstanding issues:
OK - rpmlint /var/lib/mock/fedora-rawhide-i386/result/sing-*
3 packages and 0 specfiles checked; 0 errors, 0 warnings.
OK - The package successfully compiles and builds into binary rpms on i386
(with the change I suggested)

As there are no blockers left, the package is APPROVED. Nevertheless I strongly
advice you to also apply minor corrections and improvements fro this review.
TIA.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.