[Bug 495942] Review Request: guimup - A GTKmm based drag-&-drop oriented client for MPD

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=495942





--- Comment #1 from Christoph Wickert <fedora at christoph-wickert.de>  2009-04-22 20:25:52 EDT ---
Some initial comments:

Please don't use 
%global srcname Guimup
for something that only appears twice in the spec and never changes.

Source0 gives a 403 error. This is most likely due to some weird configuration
of the server, that only allows downloading via
http://www.coonsden.com/cgi-bin/ShotGun.cgi?ammo=Guimup-stable-src
Please tell upstream to stop this nonsense if he wants his package in Fedora.

The install section is broken:
  make install DESTDIR=%{buildroot} \
   INSTALL="install -p" \
   DESTDIR=%{buildroot}
DESTDIR is used twice

  rm -rf %{buildroot}/usr/doc
/usr should not be hardcoded, use %{_usr} instead.

The package is a gui app, but lacks a desktop file. You need to add one as
described in http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files

Macro usage is not consistent, you use both $RPM_BUILD_ROOT and %{buildroot}.
See
http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS

The license is not correct. The program is GPLv3+, but the copy of libmpdclient
is under a different license.

remove libmpdclient.{c,h} during %prep, add libmpd-devel as BuildRequires and
build against it, see 
http://fedoraproject.org/wiki/Packaging:Guidelines#Duplication_of_system_libraries
This will also clear the license issue I mentioned.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.