[Bug 497338] Review Request: python-cclib - A library for processing results of computational chemistry packages

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497338





--- Comment #1 from Peter Lemenkov <lemenkov at gmail.com>  2009-04-23 10:41:27 EDT ---
Missing BR: numpy.
OK, let's assume that you added this (koji scratchbuild with numpy -
http://koji.fedoraproject.org/koji/taskinfo?taskID=1316865 )

REVIEW:

+ rpmlint is silent.
+ The package is named according to the Package Naming Guidelines.
+ The spec file name must match the base package %{name}, in the format
%{name}.spec unless your package has an exemption. [2] .
+ The package meets the Packaging Guidelines .
+ The package is licensed with a Fedora approved license and meets the
Licensing Guidelines .
+ The License field in the package spec file matches the actual license.
+ The file, containing the text of the license(s) for the package, is included
in %doc.
+ The spec file is written in American English.
+ The spec file for the package is legible.
+ The sources used to build the package matches the upstream source:

[petro at Sulaco SOURCES]$ md5sum cclib-0.91.tar.gz*
64dddde2cf1ab50cf8cb7f2882c88025  cclib-0.91.tar.gz
64dddde2cf1ab50cf8cb7f2882c88025  cclib-0.91.tar.gz.1
[petro at Sulaco SOURCES]$

+/- The package successfully compiles and builds into binary rpms on at least
one primary architecture. But only after adding numpy as BR:

http://koji.fedoraproject.org/koji/taskinfo?taskID=1316865

- All build dependencies must be listed in BuildRequires, so, please add numpy.
Definitely there are more missing runtime python dependencies - here is an
output of "find -name "*py" -exec grep import {} \; | sort|uniq":

http://peter.fedorapeople.org/cclib_imports.txt

Please, add all necessary runtime python dependencies.

+ The package owns all directories that it creates.
+ The package does not list a file more than once in the spec file's %files
listings. 
+ Permissions on files are set properly.
+ The package has a %clean section, which contains rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ The package consistently uses macros.
+ The package must contains code, or permissible content.
+ No large documentation files
+ Everytnong, the package includes as %doc, does not affect the runtime of the
application.
+ Not a GUI application.
+ The package does not own files or directories already owned by other
packages.
+ At the beginning of %install, the package runs rm -rf %{buildroot} (or
$RPM_BUILD_ROOT).
+ All filenames in rpm packages must be valid UTF-8.

So, please add the only missign BuildRequire and all missing Requires. 

Also, I'm not sure, that we should ship *.pyc-files in %doc, however this is
not a blocker.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.