[Bug 496633] Review Request: monodevelop-debugger-gdb - GDB Debugger Addin for MonoDevelop

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496633





--- Comment #6 from Mauricio Henriquez <buhochileno at gmail.com>  2009-04-24 11:34:18 EDT ---
(In reply to comment #4)

> Change the Release tag to:
> 
DONE

> 
> Ah.  Sorry.  I should have put that in the Good section.  Your encoding is
> fine.
Great

> * Still need to move the %file section to just before the %changelog section
DONE

> monodevelop is being built on:
>     ExclusiveArch:  %ix86 x86_64 ia64 armv4l sparc alpha
> 
> You probably want to go with monodevelop's version as it is the more restricted
> of the two.  Since ppc and ppc64 is left off of there, you want to follow the
Ok yes, using the monodevelop one, please check that my ExclusiveArch is ok
then, I remove the Build: noarch, that ok then?


> Yeah... I took a look.  The package has a hand-coded configure script instead
> of an autoconf generated one so it has limited options.  Try this for the
> configure line:
> 
> ./configure --prefix=%{_prefix} --bindir=%{_bindir} --datadir=%{_datadir}
> --libdir=%{_libdir}
DONE


> And it looks like you'll also have to patch one of the make files.
> 
> MonoDevelop.Debugger.Gdb.make hardcodes $(prefix)/lib/ instead of allowing
> libdir to override that.  You can patch the file or put this sed line into your
> %prep section:
> 
>   sed -i 's!INSTALL_DIR =
> $(DESTDIR)$(prefix)/lib/monodevelop/AddIns/MonoDevelop.Debugger!INSTALL_DIR =
> $(DESTDIR)%{_libdir}/monodevelop/AddIns/MonoDevelop.Debugger!'
> MonoDevelop.Debugger.Gdb.make
DONE, added the "sed" thing, don't quite sure about not make a mess with a
patch.


> So it looks like you'll need to modify the file line a little.
DONE, using:
%{_libdir}/monodevelop/AddIns/MonoDevelop.Debugger/MonoDevelop.Debugger.Gdb.dll*
now


> New things:
> 
> * You need to bump the Release: field with every revision.  Since you also want
> to add the disttag, the next release should be:
>   Release: 2%{?dist}
not sure about what to do with this, I added that and package end with
fc10.rpm...

> 
> I was able to build in mock with the changes mentioned here.  
Great, reviewd file can be found here:
http://www.ic.uach.cl/mhenriquez/fedora10-monoRPMS/monodevelop-debugger-gdb.spec.review2

> So rpmlint output
> from the packages:
> 
> monodevelop-debugger-gdb.src: E: no-changelogname-tag
> monodevelop-debugger-gdb.x86_64: E: no-changelogname-tag
> 
> * You need to add a %changelog entry to tell what you've done.  the format is
> shown here:
>   https://fedoraproject.org/wiki/Packaging:Guidelines#Changelogs
Ok I add a simple one, I try to put one in more details but as soon as I write
things like "Add sed to the %prep section.." or stuff like taht, rpmbuild claim
about thing tha he think that are "sections" and not take the text as just
comments even if put %prep in quotations..

> monodevelop-debugger-gdb.src: W: strange-permission
> monodevelop-debugger-gdb-2.0.tar.bz2 0755
> 
> * 0644 would be the normal permissions for a tarball.
Can this be fixed in the tarball on koji?, or I have to change the permission
of the tarball on the site that I put it?

> monodevelop-debugger-gdb.src: W: mixed-use-of-spaces-and-tabs (spaces: line 2,
> tab: line 1)
DONE, tabs removed

> * mono packages that only contain assemblies have no ELF files but they use
> architecture specific directories so they cannot be noarch.
Not sure what to do about this.

> monodevelop-debugger-gdb.x86_64: W: no-documentation
> 
> * In this case upstream is not providing any documentation files
Yeap no doc at the moment, so not my fault ;-) , probably because this is a
really new addin.

> monodevelop-debugger-gdb-debuginfo.x86_64: E: empty-debuginfo-package
> 
> * Presently, rpm doesn't know how to pull debug information from mono
> assemblies.  So we should be stopping the generation of debuginfo files.  This
> will change in the future.  This page has details of how to fix this:
>   
> https://fedoraproject.org/wiki/Packaging:Debuginfo#Useless_or_incomplete_debuginfo_packages_due_to_other_reasons
> 
> You want to add this to your spec file:
>   # rpm does not currently pull debuginfo out of mono packages
>   %global debug_package %{nil}  
Yeap, I read about that fixing other package, so I add the line to this one,
DONE

Thanks,

Mauricio

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.