[Bug 497525] Review Request: bubblemon-gnome - Bubbling Load Monitoring Applet for the GNOME Panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497525





--- Comment #3 from Edwin ten Brink <edwin at tenbrink-bekkers.nl>  2009-04-25 02:17:45 EDT ---
Thank you for your thorough commenting. I have two points where I need some
additional clarification.

1) I've included gettext since it does not appear to be really pulled in by
intltool, see below. Additionally it is suggested by the packaging guidelines:
"If the package includes translations, add BuildRequires: gettext. If you
don't, your package could fail to generate translation files in the buildroot."
(https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files).

$ rpm -q gettext
gettext-0.17-8.fc10.i386
$ rpm -q --whatrequires gettext
gettext-devel-0.17-8.fc10.i386
[edwin at localhost ~]$ rpm -q intltool
intltool-0.40.5-1.fc10.i386
[edwin at localhost ~]$ rpm -q --requires intltool
/bin/sh  
/usr/bin/perl  
automake  
gettext-devel  
patch  
perl(Cwd)  
perl(File::Basename)  
perl(File::Copy)  
perl(File::Find)  
perl(Getopt::Long)  
perl(Text::Wrap)  
perl(XML::Parser)  
perl(strict)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(VersionedDependencies) <= 3.0.3-1

-> Do you still feel that gettext is not required? In that case I would like to
suggest a change in the Packaging Guidlines Wiki.

2) The conversion to UTF-8 has been taken care of by the upstream maintainer
during my creation of the rpm spec file since I've found that warning too.
Since it was a 'warning' with a a 'consider' considering the two translated
manpages, I figured this would solve itself in the next upstream release.

W: file-not-utf8 /usr/share/man/sv/man1/bubblemon-gnome2.1.gz
The character encoding of this file is not UTF-8. Consider converting it in
the specfile's %prep section for example using iconv(1).

W: file-not-utf8 /usr/share/man/hu/man1/bubblemon-gnome2.1.gz
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile's %prep section for example using iconv(1).

-> Do you think the conversion is a must for this release or a nice to have? It
doesn't really bother to include in this release, but I thought it unnecessary
since I will be removing it the next release anyway.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.