[Bug 497525] Review Request: bubblemon-gnome - Bubbling Load Monitoring Applet for the GNOME Panel

bugzilla at redhat.com bugzilla at redhat.com
Sat Apr 25 21:13:08 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497525





--- Comment #6 from Edwin ten Brink <edwin at tenbrink-bekkers.nl>  2009-04-25 17:13:07 EDT ---
(In reply to comment #2)
> Preserve timestamps during install:
> 
> make install DESTDIR=%{buildroot} INSTALL="install -p"
> 
> See: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps  

This is a valid comment. I'm only wondering why the generated template spec
file does not include the part INSTALL="install -p".

Isn't this something which should be changed in rpmdev-newspec, which I used to
generate the 'offending' line? Future newcomers might be making this same
mistake again by following the generated spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list