[Bug 497756] Review Request: lpg - LALR Parser Generator

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497756


Igor Jurišković <juriskovic.igor at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |juriskovic.igor at gmail.com




--- Comment #1 from Igor Jurišković <juriskovic.igor at gmail.com>  2009-04-26 19:37:24 EDT ---
Hi Mat,

first of all this is not official review. I'm in need of sponsor.

URL:       http://lpg.sourceforge.net/
It is much better to use macro. If the package name changes you will not need
to change the url too.
URL:       http://%{name}.sourceforge.net/

You are using cp to install files. You should use install. Like:
install -pD %{name}javaruntime.jar
%{buildroot}%{_javadir}/%{name}javaruntime-%{version}.jar

When doing symlinks you don't need to change directory. You can do it this way:
ln -s ../%{javadir}/%{name}javaruntime-%{version}.jar
%{buildroot}%{_javadir}/%{name}-%{version}.jar

%description manual 
I wouldn't use that small description because many don't now what LPG is. You
could use description of LPG then simply add at the end "This is programmers
manual for LPG."

Why are you naming package lpg then later using name lpgdistribution? You
should use the real name of library as the name of the package. If you have
good reason for not doing so comment the spec file.

You are packaging manual files as different package. Why? There are only 2
files. If they are large(definition of large is left to you) package them as
%{name}-doc

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.