[Bug 497441] Review Request: mumble - Voice chat application

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497441





--- Comment #22 from Igor Jurišković <juriskovic.igor at gmail.com>  2009-04-26 19:44:15 EDT ---
(In reply to comment #21)
> specfile:
> 
> can be removed from the murmur subpackage:
> Provides:       murmur = %{version}-%{release}  
Fixed

INIT:
Fixed: /lib/lsb/init-functions
Fixed: start_daemon
Fixed: --PIDFile - it should be --pidfile
Fixed: lsb header

--chuid isn't working. Looks like that func doesn't exists. Murmur start fine
without it but with user:group root:root witch I don't want. It needs to be
started as murmur:murmur. While looking at /etc/rc.d/init.d/functions I
couldn't find any function that would start murmur as murmur:murmur. 

--RunAsDaemon doesn't exist in functions. It would be logical that when u start
app as daemon that it is already started as daemon so I dont see point in this
func?

SPEC: http://78.46.84.75:81/tj/etmain/mumble/mumble.spec
SRPM: http://78.46.84.75:81/tj/etmain/mumble/mumble-1.1.8-4.fc9.src.rpm
INIT: http://78.46.84.75:81/tj/etmain/mumble/murmur.init
DESKTOP: http://78.46.84.75:81/tj/etmain/mumble/mumble.desktop


------------------------------------------------------------------------
I just made unofficial review of LPG:
https://bugzilla.redhat.com/show_bug.cgi?id=497756

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.