[Bug 484934] Review Request: vidalia - QT-GUI for tor

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=484934


Andreas Osowski <th0br0 at mkdir.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |th0br0 at mkdir.name




--- Comment #9 from Andreas Osowski <th0br0 at mkdir.name>  2009-04-27 10:11:25 EDT ---
Package Review
==============

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines.
 [x] Spec file name must match the base package %{name}, in the format
%{name}.spec.
 [] Package meets the Packaging Guidelines
 [x] Package successfully compiles and builds into binary rpms on at least one
supported architecture.
     Tested on: 
       [x] F10/i386 
 [x] Rpmlint output:
     Source RPM:
 [makerpm at hattan vidalia]$ rpmlint vidalia-0.1.12-1.fc10.src.rpm 
 1 packages and 0 specfiles checked; 0 errors, 0 warnings.
     Binary RPM(s):
 [makerpm at hattan vidalia]$ rpmlint vidalia-0.1.12-1.fc10.i386.rpm 
vidalia-doc-0.1.12-1.fc10.i386.rpm 
 2 packages and 0 specfiles checked; 0 errors, 0 warnings.

 [x] Package is not relocatable.
 [x] Buildroot is correct
 %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other
legal requirements as defined   in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license.
     License type: GPLv2+
 [x] If (and only if) the source package includes the text of the license(s) in
its own file, then that file,     containing the text of the license(s) for the
package is included in %doc.
 [!] Spec file is legible and written in American English.
 Summary: GUI controller for Tor Onion Routing Network
 should be
 Summary: GUI controller for the Tor Onion Routing Network 
 [x] Sources used to build the package matches the upstream source, as provided 
     in the spec URL.
     SHA1SUM of package: c2ac49d051e67db9f4b15ecbdd8c02fb5a4c20be
 [x] Package is not known to require ExcludeArch
 [x] All build dependencies are listed in BuildRequires, except for any that 
     are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.
 [-] ldconfig called in %post and %postun if required.
 [x] Package must own all directories that it creates.
 [x] Package requires other packages for directories it uses.
 [x] Package does not contain duplicates in %files.
 [x] Permissions on files are set properly.
 [x] Package has a %clean section, which contains rm -rf %{buildroot}.
 [x] Package consistently uses macros.
 [x] Package contains code, or permissable content.
 [x] Large documentation files are in a -doc subpackage, if required.
 [x] Package uses nothing in %doc for runtime.
 [!] Header files in -devel subpackage, if present.
 You create a -doc subpackage, yet you do not pack the corresponding 
        header files. If you do create a -devel subpackage, vidalia should link 
        against a shared library. At the moment, vidalia has no library of its 
        own.
 [-] Static libraries in -devel subpackage, if present.
 [-] Package requires pkgconfig, if .pc files are present.
 [-] Development .so files in -devel subpackage, if present.
 [-] Fully versioned dependency in subpackages, if present.
 [x] Package does not contain any libtool archives (.la).
 [!] Package contains a properly installed %{name}.desktop file if it is a GUI 
     application.
 Fix the GenericName according to the changes to Summary (see above).
 [x] Package does not own files or directories owned by other packages.

=== SUGGESTED ITEMS ===
 [x] Latest version is packaged.
 [x] Package does not include license text files separate from upstream.
 [-] Description and summary sections in the package spec file contains 
     translations for supported Non-English languages, if available.
 [x] Reviewer should test that the package builds in mock.
     Tested on: F10/i386
 [-] Package should compile and build into binary rpms on all supported 
     architectures.
     Tested on: -
 [x] Package functions as described.
 [-] Scriptlets must be sane, if used.
 [-] The placement of pkgconfig(.pc) files is correct.
 [-] File based requires are sane.  

Remaining issues:
* -devel subpackage, see explanation above
* Fix grammar in Summary and in the desktop file
  Regardless of that, I -- personally -- would prefer the summary without the   
  word "controller" as "GUI" is completely sufficient. After all, it is a 
  Graphical User Interface. Thus, a following "controller" is not required and 
  rather confuses the reader.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.