[Bug 497786] Review Request: perl-JSON-RPC - Perl implementation of JSON-RPC 1.1 protocol

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497786


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade at gmail.com
         AssignedTo|nobody at fedoraproject.org    |panemade at gmail.com
               Flag|                            |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-04-28 00:53:23 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1325668
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
3912464c3cf59b60131fd2b15400192a  JSON-RPC-0.96.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=13,  0 wallclock secs ( 0.03 usr  0.00 sys +  0.28 cusr  0.03
csys =  0.34 CPU)
+ Package perl-JSON-RPC-0.96-1.fc12.noarch =>
  Provides: perl(JSON::RPC) = 0.96 perl(JSON::RPC::Client) = 0.93
perl(JSON::RPC::Procedure) = 0.90 perl(JSON::RPC::ReturnObject)
perl(JSON::RPC::Server) = 0.92 perl(JSON::RPC::Server::Apache2)
perl(JSON::RPC::Server::CGI) = 0.92 perl(JSON::RPC::Server::Daemon) = 0.03
perl(JSON::RPC::Server::system) perl(JSON::RPC::ServiceObject) perl(JSONRPC) =
1.01
Requires: perl(APR::Table) perl(Apache2::Const) perl(Apache2::RequestIO)
perl(Apache2::RequestRec) perl(Apache2::RequestUtil) perl(CGI) perl(Carp)
perl(Data::Dumper) perl(HTTP::Request) perl(HTTP::Response) perl(JSON)
perl(JSON::RPC::Server) perl(LWP::UserAgent) perl(attributes) perl(base)
perl(lib) perl(strict)


Suggestions:
1) For perl packages yum resolves automatic dependencies so you don't need
Requires:       perl(CGI) >= 2.92
Requires:       perl(HTTP::Request)
Requires:       perl(HTTP::Response)
Requires:       perl(JSON) >= 2
Requires:       perl(LWP::UserAgent) >= 2.001
Requires:       perl(Test::More)

remove them from SPEC.

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.