[Bug 497980] Review Request: perl-String-Diff - Simple diff to String
bugzilla at redhat.com
bugzilla at redhat.com
Tue Apr 28 09:18:10 UTC 2009
Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.
https://bugzilla.redhat.com/show_bug.cgi?id=497980
Parag AN(पराग) <panemade at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
CC| |panemade at gmail.com
AssignedTo|nobody at fedoraproject.org |panemade at gmail.com
Flag| |fedora-review+
--- Comment #1 from Parag AN(पराग) <panemade at gmail.com> 2009-04-28 05:18:09 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1326023
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
440bd85674f8602f18a2ab7978f1fa53 String-Diff-0.04.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=12, Tests=132, 2 wallclock secs ( 0.07 usr 0.01 sys + 1.93 cusr 0.10
csys = 2.11 CPU)
+ Package perl-String-Diff-0.04-1.fc12.noarch =>
Provides: perl(String::Diff) = 0.04
Requires: perl(base) perl(strict) perl(warnings)
Suggestions:
1) remove
Requires: perl(Algorithm::Diff)
from SPEC.
APPROVED.
--
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
More information about the Fedora-package-review
mailing list