[Bug 498196] Review Request: perl-WebService-Validator-CSS-W3C - Interface to the W3C CSS Validator

bugzilla at redhat.com bugzilla at redhat.com
Wed Apr 29 15:58:53 UTC 2009


Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498196


Parag AN(पराग) <panemade at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade at gmail.com>  2009-04-29 11:58:52 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1328750
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
bac54611541f72e1cfd12949afae9a1f  WebService-Validator-CSS-W3C-0.2.tar.gz

+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
 Files=1, Tests=3,  0 wallclock secs ( 0.04 usr  0.01 sys +  0.23 cusr  0.01
csys =  0.29 CPU)
+ Package perl-WebService-Validator-CSS-W3C-0.2-1.fc12.noarch =>
Provides: perl(WebService::Validator::CSS::W3C) = 0.2
Requires: perl(Carp) perl(LWP::UserAgent) perl(SOAP::Lite) >= 0.65 perl(URI)
perl(URI::QueryParam) perl(base) perl(strict) perl(warnings)

APPROVED

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.




More information about the Fedora-package-review mailing list