[Bug 497525] Review Request: gnome-applet-bubblemon - Bubbling Load Monitoring Applet for the GNOME Panel

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497525





--- Comment #8 from Edwin ten Brink <edwin at tenbrink-bekkers.nl>  2009-04-30 06:14:55 EDT ---
(In reply to comment #7)
> > - the conversion of the two manpages (languages sv and hu) since they are
> > already included by the upstream maintainer in the upcoming next release and
> > these files have a small target audience which should have the used character
> > encoding anyway.
> 
> Ok, I guess we should trust the translators here. Hope it gets fixed upstream
> though.

It currently is, the upstream maintainer assured me of this fact.

> (In reply to comment #6)
> > This is a valid comment. I'm only wondering why the generated template spec
> > file does not include the part INSTALL="install -p".
> 
> Some Makefiles already use the -p option by default, but not this one. Others
> don't understand the INSTALL parameter and will fail.

I'll see if I can get that fixed upstream as well. Perhaps it's just a question
of moving to a more recent automake/autoconf.

> REVIEW FOR gnome-applet-bubblemon-2.0.13-3.fc10.src.rpm
> Issues
> - mock build for F-11 and F-12 fails, see 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1329436
> http://koji.fedoraproject.org/koji/taskinfo?taskID=1329461

The build.log is pretty clear and fortunately identical in F11 and F12. Strange
that it does not happen under F10 or earlier (I used F9 for an earlier version,
and F10 for this submission). I will check myself as well as with the upstream
maintainer what happened.

> - SourceURL not found, see
> http://fedoraproject.org/wiki/Packaging/SourceURL#Referencing_Source
> We need a downloadable URL in the Source0 tag, use spectool to verify.

Sorry, that's my mistake. The download page on upstream's project page embeds
the source directory which is on another server. It should read:
http://savannah.inetbridge.net/bubblemon/bubblemon-%{version}.tar.gz

> - Minor: When renaming the package you forgot the comment at the head of the
> spec

I see, consider it corrected.


Because of the upcoming release of F11, I suggest not to incorporate this
package until the build issues for F11 and F12 have been resolved. I assume you
agree with me on this.

I will incorporate the above issues and revert as soon as possible. That will
probably be with a new upstream release to fix the build issues.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.