[Bug 498246] Review Request: towhee - A Monte Carlo molecular simulation code

[bugzilla at redhat.com]

Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498246





--- Comment #3 from Fabien Georget <fabien.georget at gmail.com>  2009-04-30 10:46:00 EDT ---
(In reply to comment #2)

> But you don't need to be a sponsor to do reviews, just an approved packager
> (you need to be sponsorED).
It was that I meant, I am not an approved packager. Sorry.


> > - I think that "%doc license.gpl Examples/" is not a good thing. Because
> > Examples/ contains some executable. Install it with the doc flags modify the rights.
> 
> No, it is quite standard to ship executable scripts in %doc, as the program
> works without them; they're just examples of use.
> 

If you think people don't have to run them, I think it is good.


> - In the file /usr/share/towhee/Forcefields, you remove Makefile but not
> > Makefile.am and Makefile.in
> 
> Nope,
>  find Examples/ -name "Makefile*" -exec rm {} \;
> also removes Makefile.*

I don't talk about Examples, but about /usr/share/towhee/Forcefields.

(16:21:58)-[manawy at teatime ~]$ ls /usr/share/towhee/ForceFields
Makefile.am          Makefile.in  ...

I mix the two files it's right sorry. You don't remove nothing from this file.
Anyway, Makefile.am and Makefile.in are installed but useless without the
configure script.


> 
> > - Some macros are available in rpm like %{_cat}, %{_cp} ... for coherence you  should consider to use them.
> 
> On the contrary, it is not considered clean to use macros for these sorts of
> things. Macros should only be used when absolutely necessary, not for standard unix commands as cp, mv, rm, mkdir and so on.

That's surprising ... defined but useless macros. But of course, it is not
mandatory. (And I read a new time the packaging guidelines, nothing are
mentionned about this (except for directory). It is not in this document I read
it is better to use macros. So like you want :)

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.